Pranam Lashkari
Pranam Lashkari
First example and then the actual implementation just increases the amount of work reviewers and you will have to do. Let's just review the final thing.
new functionality also needs tests...
@Sayan-Chaudhuri yes, as far as it covers the cases it is okay.
you should upload it if, it does not fit then obviously can be removed but need to have look.
can also you PR must pass all the CI checks
> Perhaps we could try testing it on latest PRs and put it at the root of the project? I agree with this. At least we can have consistent styling...
In past, I have used `git filter-branch --tree-filter` to reformate the entire code base while also maintaining the git commit history for blaming but I think this too would require...
will have a look tonight :)
@Sayan-Chaudhuri no one cares about number of lines increases due to adding necessary spaces and formatting. when in past I said that no one would require 500K lines that was...
@genofire I tried to reach the Collabora online on "http://chart-example.local:/" it leads me to default haproxy backend. am I doing anything wrong here...?