online icon indicating copy to clipboard operation
online copied to clipboard

improve HelmChart

Open genofire opened this issue 2 years ago • 5 comments

Make this HelmChart to state of the Art ;)

with nice optional Features:

  • Monitoring with Prometheus:

    • ServiceMonitor
    • Alerting (with default PrometheusRules)
    • Grafana Dashboards
  • Dynamic Config reloading:

    • extra nginx-pod (+service, + ingress)
    • json will be generated from values.yaml into a ConfigMap

After Merge, please Release it to https://artifacthub.io/

genofire avatar Sep 07 '22 07:09 genofire

Thanks for opening this pull request!

Things that will help get your PR across the finish line:

  • Check out our contributing guidelines.
  • Connect with us through one of our communication channels.
  • Click on the details link next to the failing CI checks, if any, to see an explanation on how to fix it.
  • Feel free to ping @pedropintosilva or the mentor of the easyHack you are solving if you need help.

welcome[bot] avatar Sep 07 '22 07:09 welcome[bot]

Thanks @genofire I think the issue with FreeBSD test has been fixed with https://github.com/CollaboraOnline/online/commit/b412d61ca862688c91ede459c80e98427002cac6 . Could you please rebase this PR?

pedropintosilva avatar Sep 08 '22 12:09 pedropintosilva

Done

genofire avatar Sep 08 '22 16:09 genofire

@genofire I tried to reach the Collabora online on "http://chart-example.local:/" it leads me to default haproxy backend. am I doing anything wrong here...?

lpranam avatar Sep 09 '22 14:09 lpranam

@lpranam i do not know, what do you mean - do you have your values.yml for me to understand?

PS: We use nginx, because we need multiple LBs / Ingress-Pods (and thats works with the constant hash / the annotation upstream-by-hash).

I believe you need a values.yaml like:

collabora:
  server_name: "your-collabora-comain"
  aliasgroups:
    - domain: "https://your-micro-cooloud-domain:443"
ingress:
  enabled: true
  annotations:
    haproxy.org/timeout-tunnel: "3600s"
    haproxy.org/backend-config-snippet: |
      mode http
      balance leastconn
      stick-table type string len 2048 size 1k store conn_cur
      http-request set-var(txn.wopisrcconns) url_param(WOPISrc),table_conn_cur()
      http-request track-sc1 url_param(WOPISrc)
      stick match url_param(WOPISrc) if { var(txn.wopisrcconns) -m int gt 0 }
      stick store-request url_param(WOPISrc)
  hosts:
    - host: "your-collabora-comain"
      paths:
        - path: /

genofire avatar Sep 09 '22 16:09 genofire

Any update @lpranam ?

genofire avatar Oct 02 '22 00:10 genofire

@mmeeks do you review?

genofire avatar Oct 05 '22 22:10 genofire

@genofire i will review sorry for the delay :)

lpranam avatar Oct 06 '22 00:10 lpranam

@lpranam does we want to meet (in an jitsi) to review together?

genofire avatar Oct 14 '22 15:10 genofire

@genofire that sounds great. I'd be available throughout the week at whatever time is convenient for you. I have had a glance through the PR several times but couldn't review it thoroughly. Sorry for that.

lpranam avatar Oct 14 '22 22:10 lpranam

I updated the README - here you see the result: https://github.com/genofire/collabora-online/blob/feat/helm/kubernetes/helm/README.md

genofire avatar Oct 21 '22 11:10 genofire

I create a dedicate issue for creating an repository for helm:

#5371

genofire avatar Oct 25 '22 07:10 genofire