Louis Pilfold comments

Results 1855 comments of


                                            Louis Pilfold

Same warning printed twice

> ^ This deprecation warning prints 16 times! Oops, ahahaha I presume we're checking for deprecations in the body once before and once after use is expanded?

https://github.com/gleam-lang/gleam/commit/d022ff05f2ac5126292e69eb46d725b2eadaf72a#diff-892d21f7b2f39e0c5d4ef6a85f69d96b223f6cd4309106ac900cf9c391abb183R2911 Looks like it's doing some wasteful cloning there too? It clones the call arg but discards the original?

Dependency version constraint from path dependency not respected

Thank you

Make `list.unique` logarithmic instead of quadratic

Looks like you have a compile error!

Make `list.unique` logarithmic instead of quadratic

Thank you. How does this version benchmark compared to the previous one? It would be fab to see what [this tool](https://github.com/inoas/glychee) returns for lists of different sizes.

Make `list.unique` logarithmic instead of quadratic

Are you still working on this @radekm ? Thank you

Make `list.unique` logarithmic instead of quadratic

Would anyone like to finish up this PR? 🙏

Make `list.unique` logarithmic instead of quadratic

Thank you both!!

LS: hover info for custom types and their constructors

If you have a good idea for what they would show, sounds good.

Fix seconds being returned as seconds.milliseconds in timestamps

> I think users that will want to handle milliseconds and microseconds will be able to manage this by themselves. Sorry, what do you mean by this?