Louis Pilfold
Louis Pilfold
Are we sure we want to be trimming codepoints and not graphemes? How would we ensure that the string is still valid unicode when removing codepoints?
I don't really understand what the best behaviour is here. Is there a use case that motivates making it easy to have invalid graphemes?
Those names are not acceptable in the stdlib as that's not the convention it uses. We will be deprecating trim left and right.
I do not have any firm ideas for a name, but I am also not convinced that these functions are worthwhile additions.
Sounds like the JS implementation is incorrect.
> A little bit off-topic, but why does it return an Int it should return a Float right? If round returned a float how would you round a float to...
The comments from my review haven't been addressed yet!
Sounds good, though the name proposed doesn't align with how we normally name functions. What might we call it instead?
Nice! Let's go with that