Yao Yao

Results 8 comments of Yao Yao

Idle ping/disconnect is a nice feature for lost connections. But what happens if a malicious client does not respond to a server-sent close frame, but still respond to ping? Is...

Ah, busy week ;-) I also implemented cuda-based sift months ago but recently found that yours is 3x as fast as mine. Was amazed and tried to find out why....

Yes, it is mostly memory-bound. For the DoG building, I also used similar fusion as you used. I see you are using one kernel per octave for DoG building step....

Seems this is exactly what is requested here: https://github.com/USCiLab/cereal/issues/459

@WSoptics Changed it to an option and defaults to false. Also added unit tests.

@fiesh std::optional is only available since C++17. You mean keep the option but leave it with no effect? @AzothAmmo Can we merge this feature?

It has been ~1.75 years. @AzothAmmo Do you have any concerns on this PR?

@yuziqii Would you like to create a commit including your changes? You can create an PR into my forked branch lowsfer:eliminate-empty-optional, then I merge it and your commit will be...