Peter Nemeth

Results 4 comments of Peter Nemeth

I think having attributes on logger level or on log message level support two different uses cases. The first case is useful for persistent contextual attributes, while the second when...

Hmm, I somehow missed the for of @bobhansen in the original issue which does something very similar as indicated, probably making my changes obsolete.

> The contextual logger makes things simple, and even possible to just do one message at a time. Possible, although in the current form it's neither exception, nor thread-safe. Thread...

> Could you elaborate as to how it's not exception safe? Perhaps with an example? ```cpp logger->push_context({"user_id", get_user_id()}); logger->info("some other formatted message {}", map.at(key)); logger->pop_context(); ``` If `key` is non-existent...