Lovell Fuller

Results 604 comments of Lovell Fuller

I added some debugging to libvips to track the opening/closing of profiles then ran the sharp test suite (includes CMYK to sRGB conversion, missing/broken embedded profiles etc.) and found that...

I've added fd monitoring to a (Linux kernel v4.4.x) production system but have yet to find any evidence.

```sh sudo lsof -p `pgrep node` 2>/dev/null | grep icc | wc -l ```

I've been monitoring millions of images processed each day over the last two months but have seen no evidence of this problem. @papandreou Any updates from your checks?

There have been a number of relatively minor leak-related patches to lcms2 since its v2.8 release - see https://github.com/mm2/Little-CMS/commits/master For the sharp v0.18 release, which will bundle libvips v8.5.x, I'm...

I notice lcms2 does not use the `e` "close-on-exec" flag to `fopen` ICC profiles - see https://github.com/mm2/Little-CMS/blob/master/src/cmsio0.c#L388 This means a new process spawned by an existing process could inherit open...

If your node process uses child_process, either directly or via a dependency e.g. gm, those child processes can inherit a lcms2-opened file descriptor from an in-flight sharp/libvips request in the...

Tak for the update Andreas. It's probably still worth adding the "close-on-exec" flag to lcms2 as that's still the best guess as to what was happening here.

PR for lcms - https://github.com/mm2/Little-CMS/pull/121

See https://github.com/libvips/libvips/pull/2816