Lovell Fuller

Results 604 comments of Lovell Fuller

Hello, the 128 and 256 bit hash functions were still under active upstream development until 4 days ago - see https://github.com/google/highwayhash/commit/eeea4463df1639c7ce271a1d0fdfa8ae5e81a49f - so we can now start to expose these....

Quick thought: perhaps we could use namespaced exports for this? ```javascript const { hh128 } = require('highwayhash'); hh128.asBuffer( ... ); ```

Commit a902c5f updates the HighwayHash source to latest so these improvements can now be exposed.

This module is designed to parse profiles rather than provide any conversion logic. http://www.littlecms.com/ is the "gold standard" for colour management. The A2B and B2A tags contain look-up-tables (LUTs), which...

Hello, at the moment this module only looks for tags with a `tagType` it knows about, namely `desc` and `text` - https://github.com/lovell/icc/blob/master/index.js#L83-L109 Perhaps it should provide a bit more data...

I'd be very happy to accept a new PR if you're able, thank you. The work in #3 could be used as the basis with the addition of more unit...

I like the idea of exposing the A2B and B2A tags as functions. In terms of this PR, shall we focus on exposing these tables as Buffers for now then...

What problem is this feature hoping to solve? Is there something missing from the current bug tracker? This feels like double work.

Thanks for the background information Oliver, I agree this might not currently be the best fit for libvips, which I suspect is a little more "noisy" than the average project...

Ah yes, thank you, I hadn't spotted the use of `YARN_NODE_LINKER` to create this. https://github.com/styfle/packagephobia/blob/1452f8cf2800a6c539e26304af06ce8cacaaa627/src/util/backend/npm-wrapper.ts#L16 What I believe is happening is that yarn now always copies the latest version of...