Lorenzo
Lorenzo
> @lorenzofavaro This was being worked on by another person. Did you ask @GBlanka if they were still working on it? In general you don't want to take over the...
> I'm wondering whether it would be cleaner to have entirely separate classes for double-layer or single-layer SEIs. There are a lot of if statements now in sei_growth.py @tinosulzer Could...
I'd be happy to work on this issue if possible 🙋♂️
Thanks @agriyakhetarpal. By using the nox dev session do we not also install optional dependencies? ```python # noxfile.py @nox.session(name="dev") def set_dev(session): # ... if sys.platform == "linux": # ... session.run(...
Alright, so running all the tests with the core PyBaMM gives us 68 errors, as expected. But how do we want to handle these errors for optional dependencies? Should we:...
> That is right – I believe this was overlooked in https://github.com/pybamm-team/PyBaMM/pull/3475 and we didn't realise fixing this even in https://github.com/pybamm-team/PyBaMM/pull/3848 (cc: @arjxn-py). Could you resolve that? Perhaps https://github.com/pybamm-team/PyBaMM/pull/3848#pullrequestreview-1912712047 might...