Lorenzo comments

Results 8 comments of


                                            Lorenzo

fix: improve misleading warning for progress callback exceptions

Hi @ihrpr thank you for the review. I'll add the tests.

fix: improve misleading warning for progress callback exceptions

Hi @ihrpr, ready for another pass! I've added the unit test and removed the try-except-else as you've requested.

fix: improve misleading warning for progress callback exceptions

Thank you for your reviews and comments @Kludex and @ihrpr! Totally agree with you guys and changed to `ValidationError` in the try-except. I only kept the generic `Exception` around the...

fix: improve misleading warning for progress callback exceptions

@ihrpr can you take another look?

fix: improve misleading warning for progress callback exceptions

Hi @felixweinberger, thanks for getting back to me, I'll update this PR. I am actually interested in contributing more to this repo as long as core contributors are willing to...

fix: improve misleading warning for progress callback exceptions

@felixweinberger pulled the latest changes and resolved the conflicts. But it seems that one of the tests is breaking for python `3.10` but runs successfully for other versions, interesting...

fix: improve misleading warning for progress callback exceptions

@felixweinberger thanks for moving forward with this.

[Bug]: ModuleNotFoundError: No module named 'enterprise'

I had the same problem with version `1.67.4`. I can also confirm that pinning to a previous version solves the issue: `litellm==1.67.2`