Lovro

Results 9 comments of Lovro

Hi! I will tackle with this problem.

Hi! About the progress and further work plan. After examining [LatLongEnvironmentEDF](https://github.com/appleseedhq/appleseed/blob/master/src/appleseed/renderer/modeling/environmentedf/latlongmapenvironmentedf.cpp) class and comparing it to the [OSLEnvironmentEDF](https://github.com/appleseedhq/appleseed/blob/master/src/appleseed/renderer/modeling/environmentedf/oslenvironmentedf.cpp) class I have concluded that: * `OSLEnvironmentEDF::on_frame_begin()` needs to create an importance...

OK, thank you for the hint. It makes sense. I have another doubt. How can I determine the resolution of sampling (importance map dimensions)? In OSL's test render [background](https://github.com/imageworks/OpenShadingLanguage/blob/1159d140cf7835fafaad7318a6c807582ecc06fe/src/testrender/background.h#L54) resolution...

OK, thank you for the suggestion. For now, I have hard-coded the value. First, I will perform some tests with hard-coded the value then I will try to get this...

> > Should OSLEnvironmentEDF::sample() , OSLEnvironmentEDF::evaluate() and OSLEnvironmentEDF::evaluate_pdf() have uniform sampling option if importance map is (somehow) not build or valid? In LatLongMapEnvironmentEDF only importance sampling is available. > >...

> One thing that isn't entirely clear to me: why can't you use `foundation::ImageImportanceSampler` directly, passing your own image sampler when calling `rebuild()`? Yes, you are right it doesn't make...

I was discussing the next steps with @est77. Using conclusions from that discussion I have opened an issue: #2808. So, the main idea is to transfer building importance map from...

Hi! I am quite interested in this method as well. I consider it is important for my research, therefore I have investigated the paper. There is also source code available...

Hi! Just to clarify. By "standard surface shader" is meant `renderer/modeling/surfaceshader/physicalsurfaceshader.cpp`?