Alex Soto

Results 116 comments of Alex Soto

This is what I used in all the operators I developed but of course we can try to think in a better default method.

Well `System.exit` is aggressive I know but at the end it is a Pod, I think it is a good approach as an `exception` means something went wrong (really wrong)...

Currently, we do not need this feature anymore because we bypassed this information into fake information manually. Of course, it might still be interesting to have this feature but let's...

well actually this comes of a conversation we had about allowing enrichers to choose if they want to use it or not. Missatge de Roland Huß del dia dj., 13...

Well, it is similar to buildah. We could provide support for both. It is true that nowadays kaniko is getting some traction because of tekton.

@rhuss I think we are not honoring `JAVA_OPTIONS`correctly. Look: https://github.com/fabric8io/fabric8-maven-plugin/blob/master/generator/java-exec/src/main/java/io/fabric8/maven/generator/javaexec/JavaExecGenerator.java#L166 it is returning an empty list. Then let's see how it is used in SB Generator: https://github.com/fabric8io/fabric8-maven-plugin/blob/master/generator/spring-boot/src/main/java/io/fabric8/maven/generator/springboot/SpringBootGenerator.java#L104 You see that...

Yes, it should be like this, but it will be great to support not automatic way as well El El vie, 27 jul 2018 a las 12:51, Clement Escoffier <...

What I can see is that in `VertxHealthCheckEnricher` we need two things from Maven configuration, the first one is the proeprties, and the second one the configuration. So the problem...

@rhuss You reopened this issue to improve how we can pass the custom configuration to an enricher. We didn't talk about but what could be this improvement. Do you have...

@rhuss > Maybe with a sensible default for the filename Should be the default disk-based or classpath based? Not sure about the best usage for default. If disk-based, which would...