Daniel Lorch

Results 9 comments of Daniel Lorch

In the previous message, find the raw trace of the `petadoptionhistory` (Python) service. Below, the raw trace of the `payforadoption` (Golang) service. The two services don't call each other, but...

The connection to the database is established as follows: ```python import psycopg2 conn_params = { 'database': 'adoptions', 'user': 'postgres' 'password': 'REDACTED', 'host': 'services-databaseb269d8bb-syhiyhh5ddex.cluster-c921pkk3ms9q.eu-central-1.rds.amazonaws.com' } db = psycopg2.connect(**conn_params) sql = 'SELECT...

I noticed that most of the findings relate to libraries (`requests`, `pytz`, `urllib3`), so that's best addressed there. There is one finding remaining that relates to the instance scheduler: ```...

@gockle I wonder if the highlighted block is indeed correct. Shouldn't it be: ```python def number_of_accounts(): return len(self.configuration.cross_account_roles) + 1 if self.configuration.schedule_lambda_account else len(self.configuration.cross_account_roles) ``` The total count of accounts...

The additional use-case to support for data.all is "internally routed, but not VPC-internal". ![internally-routed-use-case](https://github.com/awslabs/aws-dataall/assets/98748454/d27e4a17-ad3b-4bbb-85d4-5a3cb6355bef)

Please also update the architecture diagram to show the traffic flows. This information is required to create connectivity requests. On the architecture image https://awslabs.github.io/aws-dataall/architecture/, the traffic from the users seemingly...

Proposed configuration structure as designed with @dlpzx : ```yaml "DeploymentEnvironments": [ { "internet_facing": false, "custom_domain": { "hosted_zone_name": "dataall.example.internal", "certificate_arn": "arn:aws:acm:REGION:ACCOUNT_ID:certificate/UID" }, "apigw_custom_domain": true // NEW, default to false ... }...

The issue is not stale. I don't seem to have permissions to remove labels.