Ludovic Orban

Definitely, QTP's getters and javadoc need updating so I'm happy with that change. But the _not reserving a thread if there are queued jobs waiting_ part is IMHO problematic and...

I've written an attempt at a limit test to see how this change impacts performance, see the new `AESLimit` class. On my machine, it seems that with this change: -...

After discussing with @sbordet, we agreed that the `AESLimit` test was not measuring what it was supposed to. Another attempt had been made, and the fundamental end result is similar...

> @sbordet @lorban There are only a few explanations for this PR causing increased latency: > > 1. The test/benchmark is wrong It's always a possibility that the benchmark isn't...

This has no measurable perf impact in the Core API: https://jenkins.webtide.net/job/load_testing/job/jetty-profiler-12.1.x/44/artifact/core/target/reports/CoreHandlerPerfTest_testNoGzipAsync/ according to our standard benchmark once I removed the `System.err.println()` calls in `isReservable()`. (main branch reference: https://jenkins.webtide.net/job/load_testing/job/jetty-profiler-12.1.x/41/artifact/core/target/reports/CoreHandlerPerfTest_testNoGzipFullyAsyncHandlerTree/)

Reminder of our last discussion: I'm okay with this change (after its gets cleaned up and reviewed) if we also change the heuristic that picks the default # of reserved...

@gregw I think we should use a hardcoded number like 8 or 10 instead of the #cores as running Jetty on some 2 vCores K8S virtual machines is far from...

Can you share an example of subclass you'd like to create? Feel free to modify `ResourceService` as you wish, we'll consider the best way to achieve your goal. Thanks!

Opening up the internals of `ResourceService` as an API looks sketchy to me, so I agree with @joakime that adding a method to add a `Predicate` filter that would be...

@gregw AFAICT in 12.1.x `ResourceService` has everything needed to be able to do just that: `sendDirectory` now accepts a `Resource` instead of a `HttpContent` so you can easily substitute the...