Ludovic Orban

Results 180 comments of Ludovic Orban

Speaking about the design, I see two problems if you configure a moderately large throughput (say 10K req/s): - You need to allocate an array with one 64-bit entry per...

> Let's discuss this face to face. Count me in.

Implementation-wise, this looks alright assuming the same logic can be replicated in H2/H3 (but I doubt this is going to be troublesome). But could you summarize what benefits/drawbacks this has...

@gregw I'm going to take care of both H2 and H3 as they're going to be very similar.

`HttpInputIntegrationTest` in ee11 fails by reporting a buffer leak. Otherwise, LGTM.

@gregw [the full log](https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/PR-12077/44/tests) shows 3 leaks, as summed up by the `Expected: is but: was ` failure: first one is during write: ``` TrackedBuffer@17ea9c4f of 32768 bytes on 2024-10-23T07:32:30.613161227Z...

Between Jetty 12.0.7 and 12.0.8, cross-context dispatching was re-introduced. This changed touched a lot of code related to this issue so while I suspect it is the change that introduced...

By any chance, have you collected a heap dump of the JVM that encountered that leak that you could share with us? Thanks!

Here is a short list of things from this heap dump that could help us: - the capacity of the leaked buffers - if they're direct or not - the...

An alternative to using a leak-resistant pool is to wait for the soon-to-be-released Jetty 10.0.23 and use the new [leak tracking pool](https://github.com/jetty/jetty.project/pull/12041) so the pool can collect data about the...