loqs
loqs
I am not sure I made the change you requested correctly: ```patch diff --git a/cmake/autoheader.cmake b/cmake/autoheader.cmake index df61622..883ff48 100644 --- a/cmake/autoheader.cmake +++ b/cmake/autoheader.cmake @@ -21,7 +21,7 @@ if (NOT PUPNP_VERSION_STRING)...
Did I misunderstand you and the change you meant was: ```patch diff --git a/cmake/autoheader.cmake b/cmake/autoheader.cmake index df616225..e79e963f 100644 --- a/cmake/autoheader.cmake +++ b/cmake/autoheader.cmake diff --git a/cmake/autoheader.cmake b/cmake/autoheader.cmake index df616225..ce655a6e 100644 ---...
@Vollstrecker the second change I mentioned fixes it for me.
@brechtvl I noticed this pull request now has merge conflicts.
Does https://github.com/oneapi-src/level-zero/pull/149 allow you to build with the system spdlog and libfmt? For me it failed to link properly.
@luyatshimbalanga that patch fails for me as it does not link to the system libraries. It would use the headers if they are already on the default search path. Could...
This fails for me when using the system spdlog as if `spdlog_FOUND` is set then the system library is not added to the targets link libraries.
> Would moving from fetchcontent to a submodule make this any better? I presume it would since the submodule would get fetched before build-time. Would you consider moving the fetch...
> It would certainly be possible. Is it a drop-in replacement, or is there a migration guide somewhere? Have you considered approaching https://codeberg.org/daniel-casanueva which I believe is the current maintainer...
@amini-allight should the version check for boost in CMakeLists.txt not have its version increased from 1.39.0 and a version check added to SConstruct? Similarly if the minimum version of boost...