Lomig Mégard

Results 16 comments of Lomig Mégard

You're right that we are using the immutable `Seq` collection in all our APIs. This is however a design choice, as we prefer enforcing strict immutability on such public APIs....

Hi @ahmedhamdy88 , This is an interesting point you made. I read again the W3C specs, regarding the origin (for both actual and pre-flight requests): > If the value of...

Hi, Could you also send the corresponding full requests (including headers) ? Note that your `Origin` request header (see https://www.w3.org/TR/cors/#origin-request-header) must follow [rfc6454](https://tools.ietf.org/html/rfc6454#section-7.1) syntax, which *does not* include a path....

Hi! Could you provide an example request/response and the full settings you are using? akka-http is not aware of its "same" origin and treat it as any other origin.

> Build is failing due to the following: > > 1. tests defined on `PartitionedJournalSpecTestCases` trait ([PostgresJournalSpec.scala](https://github.com/SwissBorg/akka-persistence-postgres/blob/master/core/src/test/scala/akka/persistence/postgres/journal/PostgresJournalSpec.scala)) > > 2. tests defined on `JournalSequenceActorTest` abstract class ([JournalSequenceActorTest.scala](https://github.com/SwissBorg/akka-persistence-postgres/blob/master/core/src/test/scala/akka/persistence/postgres/query/JournalSequenceActorTest.scala)) > The name...

Any update on this? Almost 2MB are added into the fat jar for nothing, requiring a custom `assembly` merge strategy.

@sksamuel I will try to have a look in my spare time then ;)

You mean the byte array allocated in `BaseMarshaller` to read from the `InputStream` (only API provided by `io.grpc.MethodDescriptor`) ? Might be linked to this PR: https://github.com/akka/akka-grpc/pull/1318/files#diff-1a02adbd4ed9c032022756fe7dbbac1e967816613c7f1adef4f3e2330136fa11L22 Actually I didn't see...

I recently got bitten by `MessageDigest` dummy implementation. I would have expected an error at linking or runtime, instead of returning erroneous values. For the reasons mentioned above, it might...

Hi @ahjohannessen , Would you have time to have a look at this PR? It exposes the service descriptor to the generated gRPC service companion objects. There could be alternative...