logto icon indicating copy to clipboard operation
logto copied to clipboard

feat(connector): postmark email connector

Open srs opened this issue 1 year ago • 5 comments

Summary

Implemented a Postmark email connector that uses Postmark API rather than SMTP. This provides the ability to use templates stored in Postmark instead of the templates stored in JSON.

This is implemented by looking at connector-sendgrid-email and implemented it as my understanding of best practices and convensions.

Testing

Have a simple uint-test that only checks configuration is valid (as also connector-sendgrid-email has). Else I did manual testing by connecting it in Logto UI and sending a test email trough the UI. Have also tested it in real-world scenarios by connecting it to an email provider.

Checklist

  • [x] .changeset
  • [x] unit tests
  • [ ] integration tests
  • [ ] necessary TSDoc comments

srs avatar May 16 '24 18:05 srs

COMPARE TO master

Total Size Diff :warning: :chart_with_upwards_trend: +26.48 KB

Diff by File
Name Diff
.changeset/bright-carpets-relax.md :chart_with_upwards_trend: +67 Bytes
packages/connectors/connector-postmark/README.md :chart_with_upwards_trend: +1.98 KB
packages/connectors/connector-postmark/logo.svg :chart_with_upwards_trend: +2.26 KB
packages/connectors/connector-postmark/package.json :chart_with_upwards_trend: +1.88 KB
packages/connectors/connector-postmark/src/constant.ts :chart_with_upwards_trend: +1.34 KB
packages/connectors/connector-postmark/src/index.test.ts :chart_with_upwards_trend: +1.18 KB
packages/connectors/connector-postmark/src/index.ts :chart_with_upwards_trend: +1.67 KB
packages/connectors/connector-postmark/src/mock.ts :chart_with_upwards_trend: +573 Bytes
packages/connectors/connector-postmark/src/types.ts :chart_with_upwards_trend: +1002 Bytes
pnpm-lock.yaml :warning: :chart_with_upwards_trend: +14.56 KB

github-actions[bot] avatar May 16 '24 18:05 github-actions[bot]

This solves #5885.

srs avatar May 16 '24 18:05 srs

@wangsijie @darcyYe can you guys take a look thx.

simeng-li avatar May 17 '24 03:05 simeng-li

Also, it would be nice if you can make the commits signed.

wangsijie avatar May 17 '24 06:05 wangsijie

I will add some basic tests and do signed commits.

srs avatar May 17 '24 22:05 srs

Hey just ask our designer to create a logo for you.

logo

charIeszhao avatar May 29 '24 04:05 charIeszhao

The pnpm lockfile seems to be corrupted. Please try to resolve this issue in order to pass the CI checks.

Usually this can be resolved by running pnpm i

charIeszhao avatar May 29 '24 05:05 charIeszhao

@srs

ErickLuis00 avatar Jun 17 '24 23:06 ErickLuis00

This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 02 '24 01:07 github-actions[bot]

Sorry for this. Will be right on it after my vacation that ends in 4 days :)

srs avatar Jul 05 '24 17:07 srs

This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 23 '24 01:07 github-actions[bot]

We can replace the logo before merging.

darcyYe avatar Jul 30 '24 02:07 darcyYe