logto icon indicating copy to clipboard operation
logto copied to clipboard

feat(core): add DELETE /custom-phrases/:languageKey route

Open IceHe opened this issue 3 years ago • 2 comments

Summary

  • Add DELETE /custom-phrases/:languageKey route
    • If the specified custom phrase does not exist before deleting, it will return 404 status.
    • If the specified custom phrase exists before deleting, it will return 204 status when the process succeeds.

Testing

Locally tested.

image

First deletion (the specified custom phrase exists before deleting)

image

Second deletion (the specified custom phrase does not exist before deleting)

image

IceHe avatar Sep 13 '22 10:09 IceHe

LOG-4059 DELETE /custom-phrases/:languageKey

Type: management route

Delete the custom phrase of the specified language.

linear[bot] avatar Sep 13 '22 10:09 linear[bot]

COMPARE TO master

Total Size Diff :chart_with_upwards_trend: +1.84 KB

Diff by File
Name Diff
packages/core/src/queries/custom-phrase.ts :chart_with_upwards_trend: +358 Bytes
packages/core/src/routes/custom-phrase.test.ts :chart_with_upwards_trend: +1.1 KB
packages/core/src/routes/custom-phrase.ts :chart_with_upwards_trend: +401 Bytes

github-actions[bot] avatar Sep 13 '22 10:09 github-actions[bot]