Jonathan Gilbert

Results 79 comments of Jonathan Gilbert

Rebased. I thought I was working with the latest `master`, but I wasn't. The change is now in terms of the latest `master`.

Any changes you'd like to request on this PR? :-)

I have implemented the proposed algorithm for excluding impossible values from the range by bumping `start` forward and `end` back, along with unit tests that detect the correction.

There were some shenanigans surrounding `Kind` and offsets but that's now sorted out. For your test, with `start` set to 1 minute before the end of the transition and `end`...

I have found an edge case :-) If the requested range starts exactly at the beginning of a transition window and ends exactly at the end of a transition window,...

Sorry, I don't normally do so many force-pushes, but in my eagerness I'm afraid I pushed changes only to realize a few minutes later that I had overlooked a case...

If you can identify what the actual tests are, I could look at creating automated tests to cover that as part of this PR.

The code has changed since then. I'll run the same test, see what happens. :-)