devpod icon indicating copy to clipboard operation
devpod copied to clipboard

fix(ssh-workspace-id): fixes parsing for git ssh urls

Open tommatime opened this issue 1 year ago • 1 comments

Issue: When creating a workspace from a git repository using an SSH URL, the ID parser does not properly detect the repo name. For example, the command devpod up [email protected]:loft-sh/devpod.git results in a workspace ID of "github-com-loft-sh-devpod". When created via HTTPS, the workspace ID is "devpod".

Expectation: The workspace ID generation should be consistent across git URLs.

Fix: The fix is to detect the presence of ":" when "@" is present - if so, we can use the standard parsing mechanism that uses the last index of "/" and strips ".git".

Notes: This is my first contribution to this project. Please let me know if this is the expected functionality, if my implementation may have unwanted side effects, or if I need to update any tests/documentation. Thanks!

tommatime avatar Nov 21 '24 03:11 tommatime

Hey @tommatime, welcome to DevPod and thanks for the contribution 🙌 The source parsing is a bit finnicky so let's run the tests and see what happens

pascalbreuninger avatar Nov 26 '24 13:11 pascalbreuninger