Loet Jansen van Rensburg
Loet Jansen van Rensburg
I believe I have this one sorted as well. I will open a PR after #369 cause I need those changes
I was able to allow the previous generic type as well. So everything should work as expected now.
Ok I see here we have test:v2 and test:v3 which I didn't run cause CONTRIBUTING.md only indicated test. I will have a look at these. I was also using docker....
Seems my tests we returning cached results so was not seeing all the type errors. The type errors should pass now but I did see some timeout errors which I...
a problem I see in the tests are that the model and schema gets modified further down the chain which then doesn't work with Typescript cause it compares with the...
The changes I introduced based on the previous open PR is just adding types so I think we should be good on the backwards compatibility part. I think it would...
No problem glad to help as I am starting a few projects using this repo. I fixed the conflict.
bleh ok I will fix these test issues
> The src/Table.d.ts has a lot of formatting changes. I'd like to revert those so we can focus on only the changes. We'll need to stick to the prior formatting...
fixed the formatting. I did discover that the model suggestion is not working. So you could add any model and its not type checking that the model exists. It was...