ndcurves
ndcurves copied to clipboard
loco-3d
polynomial type with non Eigen types
In the current implementation of the polynomial class, the coefficients are stored using an Eigen matrix and not a vector. If other types are used (such as linear_variable), the polynomial class will not work. We should either change this or remove the point type form the template definition as it is useless. The coefficients should be stored as std::vector.
Is there any reasons this has been done differently ? @JasonChmn @proyan
Moreover you cannot create a simple 1D polynomial easily like this.
I was looking for a simple min jerk solver, I managed with ndcurves but it's a bit convoluted to use Eigen::Vector::One(1) for the initialization.
Indeed. Do you have any suggestions on how to avoid that?
From: Naveau @.> Sent: 04 March 2022 19:03 To: loco-3d/ndcurves @.> Cc: TONNEAU Steve @.>; Author @.> Subject: Re: [loco-3d/ndcurves] polynomial type with non Eigen types (#53)
This email was sent to you by someone outside the University. You should only click on links or attachments if you are certain that the email is genuine and the content is safe.
Moreover you cannot create a simple 1D polynomial easily like this. I was looking for a simple min jerk solver, I managed with ndcurves but it's a bit convoluted to use Eigen::Vector::One(1) for the initialization.
— Reply to this email directly, view it on GitHubhttps://github.com/loco-3d/ndcurves/issues/53#issuecomment-1059435978, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABDIFJUPNO3XMLSBIBVTVQ3U6JM63ANCNFSM4R3WIC2A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>
The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.
Yes we should be implementing the template specialization for the type double.
The size of everything should be considered 1 or have an inner converter from double to Eigen and use the current implementation.
Not sure what is the best way... I am a very new user of ndcurves.
We had that before, but the issue is with the python bindings I think. @JasonChmn could you recall the issue