Logan Adams

Results 294 comments of Logan Adams

> Looks like v2 will not be compatible with v1 - we will need to add `pydantic>=2.0.0` to requirements once we make the switch. It might be worth adding `pydantic

For some reason the build can show as passing but only the cuda job passes, the rocm/rocr one fails.

Can you test again with the latest DeepSpeed with the triton versions updated? If you are still seeing this, can you re-open this issue?

@hayday100 - for now, can you use the triton version listed in requirements-sd.txt? That version specifically works when running our unit tests.

Hi @TinyQi - did you mean to make this a new issue? This looks like it is still being covered in the original linked issue. @khai0617 - what parameters you...

Closing this issue for preference to track in the main issue. If you need this one re-opened with a different question, please re-open.

> @loadams any update/ETA on this PR? > > FYI, I just rebased from master. Please, let me know if there is anything else I can do to facilitate reviewing/merging...

Hi @MrZhengXin - could you elaborate more on the question?

Thanks, @cli99 is probably most well suited to answer this.