Lukáš Nykrýn comments

Results 18 comments of


                                            Lukáš Nykrýn

fix(dracut-install): do not try to copy files from the root directory

LGTM as well

New Module: add the 99overlayroot module

Just a note here, I don't think that GPL v2, which we used for dracut is compatible with AGPL used here.

fix(dracut-init.sh): add missing hostonly code in the inst_multiple function

Hmm, do we know why inst_multiple does not process -H? THis seems wrong to me.

fix(dracut-init.sh): add missing hostonly code in the inst_multiple function

Yeah, I agree, but my question is why the code is different from the other functions.

fix(dracut-init.sh): add missing hostonly code in the inst_multiple function

I don't know; it still looks like Harald forgot to add the same code in inst_multiple. But probably I am missing something.

fix(dmsquash-live-root): check kernel for built-in `overlay` drivers

LGTM

Run systemd-sysusers when generating initrd

> Such a patch would then have to use the systemd sysusers files that we are shipping with our modules ( and being shipped with modules that reside outside our...

Run systemd-sysusers when generating initrd

And also to back up my proposal. In a normal system we have ConditionNeedsUpdate just because we need to run the service when etc or usr change. Those are static...

fix(systemd-pcrphase): rename systemd-pcrphase binary to systemd-pcrextend

Wouldn't this break compatibility with older systemd?

fix(dracut-lib): use poweroff instead of halt

> This looks good to me, but for consistency should the following change as well to poweroff instead of halt (in dracut-lib.sh). > > ``` > source_hook "$hook" > warn...