openMMC icon indicating copy to clipboard operation
openMMC copied to clipboard
verified publisher icon lnls-dig

Added support for new boards

Open atcher0 opened this issue 4 years ago • 2 comments

New boards:

  • AFCZ (https://github.com/elhep/AFCZ)
  • RTM 4SFP 3QSFP (https://github.com/elhep/RTM_4SFP_3QSFP)
  • SAYMA AMC (https://github.com/sinara-hw/Sayma_AMC)
  • SAYMA RTM (https://github.com/sinara-hw/Sayma_RTM)

atcher0 avatar May 31 '21 14:05 atcher0

Hi @atcher0, thank you for the contribution!

We reserve the master branch for stable releases only, please rebase your modifications with our devel branch.

This is a big PR that will need a more careful examination before merging, I already see some conflicts with AFCv4 support code.

augustofg avatar May 31 '21 15:05 augustofg

Hi, my changes are now rebased onto the devel branch.

atcher0 avatar Jun 02 '21 20:06 atcher0

Unfortunately, this is not possible to merge due to the recent developments of OpenMMC. Support for INA3221 and 8V54816 is already there, so this would generate conflicts. We are migrating away from the GitFlow workflow now, so new PR should be targeting master.

Please open small PRs for each new feature, so it is easier to review and run the CI checks.

augustofg avatar Jul 22 '24 12:07 augustofg