Luisa Vasquez

Great time to raise this up. MSVC support is on the way as we speak, we've been modifying out cxx rules which are quite clang centric to also support the...

Just tried it! Works like a charm. Thanks @dtolnay! With that our hello_world example works using this toolchain: ``` system_cxx_toolchain( name = "cxx_win", visibility = ["PUBLIC"], compiler = "windows", cxx_compiler...

If you're using Visual Studios environment (which is usually the case for MSVC) they should be on the path. It could still be hard coded on the toolchain for when...

Thanks for the fix! Could we do this in a way that we're not applying the dep files parsing to the error itself? Something like `if line.startswith(".") and returncode ==0`....

The fact that you can run your cxx binary without any issues is already a good sign, I'd recommend making sure depfiles are being generated by using `buck2 audit depfiles`...

I'm not a clang expert but I'd say it's rather unlikely the dep file will be generated if compilation failed, therefore, adding `if returncode ==0` will just guarantee compilation succeeded...

Sound like a good plan, thanks for explaining! By depfile I meant the general output of repeated `./path/to/dep`, when I implemented this there wasn't many cases internally where we'd get...