Loic Nageleisen

Results 174 comments of Loic Nageleisen

Noticed the separator was off for Windows, which would break the replacement and made a fix, but it insists on having `C:` in front still :( ``` [00:02:28] Starting Vader:...

@w0rp there were a few corner-case bugs but it's all fixed and test-covered now. WDYT, good to merge?

Hmm, missed [that one](https://github.com/dense-analysis/ale/actions/runs/9291850874/job/25986245530?pr=4671#step:3:15) locally, will fix: ``` ======================================== Running Vint to lint our code ======================================== Vint warnings/errors follow: ale_linters/ruby/steep.vim:26:21: Use robust operators `==#` or `==?` instead of `==` (see...

Oh my, thanks @hsanson! Just pushed fixes for the remaining bits. Let's see if CI is green now.

Here's a quick run of https://github.com/socketry/rack-conform as was suggested by @ioquatix: ``` 6 passed 2 errored out of 8 total (11 assertions) 🏁 Finished in 5.9ms; 1854.349 assertions per second....

This is fixed: ``` file test/rack/conform/streaming/body.rb it can stream a response test/rack/conform/streaming/body.rb:12 ⚠ EOFError: Could not read line! ``` The last error is more about implementing WebSocket support in Thin...

Huh I can't find it now. Maybe I got confused.

Heh I already have a branch locally, I just need to push and create the PR there :) I'm a bit surprised about Rack 3 mandating WS support, but whatever....

> rack-conform test suite passing. which means websocket support > any update on this? I've been: - exploring eventmachine a bit to either directly get to the socket or hack...

>> which means websocket support > You only need to support streaming responses, which is not the same as WebSockets. It's the same as partial hijack. Even puma can support...