Loic Nageleisen

Results 176 comments of Loic Nageleisen

Example: ``` # foo.rb class Foo def test(a) puts a end end Foo.new.test('hello') ``` ``` # foo.rbs class Foo # def test: (::String) -> void end ``` Steps to reproduce:...

There are two things happening here that should be split: - setting the configuration settings for Sinatra+Rack, which should be done immediately (not delayed to a later time): - saying...

Sorry to hear that! Thanks for the minimal repro, that's super helpful. I will take a look today. @agrobbin just in case, can you give me the motor-admin version in...

Here's the result of my analysis. The issue comes from `ActionDispatch::Journey::Router#find_routes` called by `ActionDispatch::Journey::Router#serve`. [Inside `serve`](https://github.com/rails/rails/blob/v7.0.8.1/actionpack/lib/action_dispatch/journey/router.rb#L31), [Rails 7.0 (down to 4.0) does](https://github.com/rails/rails/blob/v7.0.8.1/actionpack/lib/action_dispatch/journey/router.rb#L32): ``` def serve(req) find_routes(req).each do |match, parameters, route|...

AIUI in the provided repro it seems that `get motor_admin.motor_path` does not hit any route known to the router (maybe it's missing the `/admin` prefix?) and thus produces the reported...

As it stands I found the following corner case: ``` c.service = 'puma' c.tracing.instrument :rack, service_name: 'rack', request_queuing: true, web_service_name: 'nginx' c.remote.service = 'rack' ``` RC sees `rack` but not...

Found another case that we can't easily automatically; the public tracing API allows: ``` Datadog::Tracing.trace 'my-span-name', service: 'my-service-name' do # things being traced end ``` The service name is then...

By the way @idanci I saw you mentioned this: > Cannot debug locally as appsec doesn't run on M1 cpu. I am curious as to why it would be the...

> I have a huge user base already forming Great! > and they definitely want tabs for teams My vision was to have something simple: one window per configured URL...

Damn, forgot the doc. Will fix later.