Loic Nageleisen
Loic Nageleisen
Closing, superseded by specs added as part of #2306.
@marcotc This is a bit trickier than expected because of additional indirection in the new `Promises::ChainPromise#on_resolvable`, but I got something running. I'll clean that up next week and push a...
Thanks Ivo! Right now I'm on another goal until October starts, then I should have some time to finalise the PR Ivo mentioned.
>> Also noticed that ddtrace 1.0.0 adds a dependency on [libddwaf](https://github.com/DataDog/libddwaf) gem. The [changelog](https://github.com/DataDog/libddwaf/blob/master/CHANGELOG.md) describes all releases since 2020 as “unstable”, which doesn’t really inspire confidence. > > I believe...
This looks nice to me as a first validation step. It will get better with the tracer instrumentation DSL we talked about though, which we should probably wait for before...
Duh, one lousy test on my part. Will fix.
> avoid (potential?) infinite recursion That triggered during a rspec run, so unless the behaviour is spec-induced it had a chance of happening for real. > Having all these changes...
> I'd be curious to see what happened -- was the patch applied more than once? Just to make sure we're fixing it properly with the prepend version. Yup, now...
> Can you look into #1522 (comment) as well? I was just typing it out ;) > I'm not entirely a fan I wasn't aware of this PR, and I'm...