Lin
Lin
> @lliiun-z you can mark it as draft PR if it is not ready for review How to make it as draft? in the title?
The test failure is not related to this PR.
> Can we look in to the build failures? and fix the PR commit and description with appropriate details? Done.
> The PR description is very FB specific, can we make it generic? And also move the FB specific details to facebook PR. Make sense. Will do.
@jainxrohit, @rschlussel please review, all the comments have been addressed. Thank you!
This test failure is not related to this PR.
> I started review, but I think there are some basics about the PR that I don't understand. I think my main question is: what are we trying to collect...
I am trying to see if I can use partition.parameters to store and retrieve the lastDatacommitTime. If so, we can avoid the confusion between lastDataCommitTime and lastAccessTime.
> This approach is much nicer! Can you also add some tests? Will do.
> This approach is much nicer! Can you also add some tests? Added some test for checking the partition params.