Lei Liu

@iuhilnehc-ynos Thanks for your tip, I have created PR https://github.com/ros2/rclcpp/pull/2044 to fix this issue.

@fujitatomoya > can you make sure https://github.com/ros2/rclcpp/issues/2039#issuecomment-1303160571 is the case for this issue Confirmed, and it works well (the test case passed, no hang happend). > with using gdb or...

@jefferyyjhsu I retest it on humble branch, and it works well (both on latest rolling & humble branch): ```bash ... 100: [INFO] [1667963086.523220110] [server_node]: Received service client request... Sending response:...

@jefferyyjhsu I used default env of latest ros:humble docker (with some extra packages installed for compiling rclcpp): ``` root@csc:/work/rclcpp_issues_2039# dpkg -l | grep fastrtps ii ros-humble-fastrtps 2.6.1-1jammy.20220620.173333 amd64 *eprosima Fast...

I found `set_parameters` does not send parameter event in batch, ```c++ std::vector NodeParameters::set_parameters(const std::vector & parameters) { std::vector results; results.reserve(parameters.size()); for (const auto & p : parameters) { auto result...

@clalancette Many thanks for your reply.

In my option, `declare_parameters` maybe reasonable for user, bellow are the declaration: ```c++ std::vector declare_parameters( const std::string & namespace_, const std::vector & parameters, bool ignore_override); std::vector declare_parameters( const std::string &...

> It also occurs to me that we could use a Factory style pattern here, where we have convenience functions like overloads 3 and 4 above good idea.

Hi All, I have create/refactory declare_paramters/_atomically staff, see #1991 for detail, as decribed in https://github.com/ros2/rclcpp/issues/1970#issuecomment-1204859142, when calling declare_parameters/_atomically, if failed(some parameter are invalid), the declare_parameters/_atomically will recover to original status...

@fujitatomoya This PR still in progress, testcases and some feedbacks will be processed.