Levi Kilcher

Allow Velocity or Dataset inputs for API functions

4

The idea here is that API functions (such as `rotate2`) can handle (take as input and return the matching dtype) either `xarray.Dataset` or `velocity.Velocity` objects. i.e.: dsi = dolfyn.read('some raw...

Handle external heading input

1

Are RDI instruments the only ones that can take external heading data (e.g., GPS NMEA strings)? If so, we will need to take care in how we handle those data....

Warn on setting 'protected' entries in `dat.props`

1

We need a warning when a user tries to set a value of `dat.props` that is supposed to be protected.

Missing timestamps

1

While working on #76 I realized that I can't put `np.datetime64('NaT')` into the `ds.time`. However, this causes problems because sometimes timestamps really are missing. We need to figure out a...

Rotate-variables list

2

We should probably change from the list `ds.attrs['rotate_vars']` to a *DataArray* attribute flag (e.g., `ds['vel'].attrs['rotate_me']=True`). Then we loop over all of the variables to identify which ones should be rotated....

In the process of reviewing #67, I've realized I use `demean` and `detrend` rather inconsistently (e.g., in `calc_acov`, `calc_xcov` vs. `calc_tke` and `calc_stress`) and without a clear rationale? It seems...

prcnt_gd seems backward

2

The values of `dat.signal.prcnt_gd` for RDI ADCPs seems backwards (good values have values of 0, and bad values have values >0).

The error velocity (from RDI's) is not documented. It is currently located here: `dat.vel[3]`.

Currently when data is in beam-coordinates, only variables in `dat.props['rotate_vars']` that start with `'vel'` are rotated to beam coordinates. This is because this is how most manufacturers handle data internal...