Jihyun Kang

Results 58 comments of Jihyun Kang

Let's add a certain guide for splitting `render()` function defined in each component.

Here's good example for splitting `render()` function. https://lit.dev/docs/libraries/standalone-templates/#render-dynamic-data

@Taewan-P Recently session launcher dialog has been updated and It seems that this bug was resolved via #1009. So, @inureyes or @adrysn could double-check and close this issue.

I think we need to make a decision since we are now facing the need for exception handling across the component, which seems a bit too big to handle here....

@Sujin-Kim1 FWIW, I think we could use "lablup-slider" rather than plain text field in order to describe what the amount of the value means. Perhaps like this? ![1_HSdwlQS2XBgAaUUNu_Mf4A](https://user-images.githubusercontent.com/46954439/190341098-74b88ece-d5ff-4cb2-b90c-003e9c706404.gif) (ref: https://uxplanet.org/4-creative-concepts-of-slider-control-1f8839b05943)

To apply those UI, we need to separate the issue into two. - [ ] Refactor lablup-slider or Create another slider component that supports color-adjustable option by range. - [...

@adrysn Is there any chance of incrementing "tags" more than three, such as "lablup/python-kaldi:2.0-py27-cuda10.0-mlflow1.7-01" or "lablup/python-kaldi:2.0-py27-cuda10.0-mlflow1.7-01-arm64"?

@inureyes To my knowledge, for providing a better user experience, we limited tags to at most 3. But, It's true that we also allow adding tags more than that, so...

Closing this issue since it's been obsolete. We don't use piechart in storage-proxy component.

> IMO, there are a few requests written in the comments and also one more thing to be fixed before merging this PR. TL;DR: We need to change the code...