backend.ai-webui icon indicating copy to clipboard operation
backend.ai-webui copied to clipboard

Show warning dialog when setting rate limit below 100

Open inureyes opened this issue 2 years ago • 4 comments

Main idea

The rate limit function limits the number of API calls per 900 seconds to prevent unexpected DDoS attacks and API abuse. However, if this value is too small, API operations such as login using API calls will also be blocked.

The rate limit value is also used to block spammers, so the setting can be as small as 1 as before, but when setting a value less than 100, let's improve the user interface to provide a warning and a dialog asking to continue.

Alternative ideas

No response

Anything else?

No response

inureyes avatar Sep 09 '22 02:09 inureyes

When the rate limit value is lower than the warning threshold, I am debating whether to display the validity as false or change the color of the helpertext. Since it is a settable value, validity cannot be considered false, but it has the advantage of being able to see a warning message immediately along with the user's input. On the other hand, helpertext has the disadvantage that it cannot be reflected immediately along with the user's input, but it is theoretically appropriate. (valid)

agatha197 avatar Sep 14 '22 18:09 agatha197

@Sujin-Kim1 FWIW, I think we could use "lablup-slider" rather than plain text field in order to describe what the amount of the value means. Perhaps like this? 1_HSdwlQS2XBgAaUUNu_Mf4A (ref: https://uxplanet.org/4-creative-concepts-of-slider-control-1f8839b05943)

lizable avatar Sep 15 '22 07:09 lizable

To apply those UI, we need to separate the issue into two.

  • [ ] Refactor lablup-slider or Create another slider component that supports color-adjustable option by range.
  • [ ] Apply "custom slider" to rate limit section.

lizable avatar Sep 15 '22 07:09 lizable

Let's add option to Lablup-slider!

inureyes avatar Oct 20 '22 06:10 inureyes