Burt

Some Reader functions are Duplicated. - [ ] Read `ClientStates`: duplicated for 3 times. [Implemented in channel.rs](https://github.com/octopus-network/substrate-ibc/blob/ee60ff6bef9fab48583253cd23b6da326cdac203/src/channel.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L86); [Implemented in client.rs](https://github.com/octopus-network/substrate-ibc/blob/ee60ff6bef9fab48583253cd23b6da326cdac203/src/client.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L43); [Implemented in connection.rs](https://github.com/octopus-network/substrate-ibc/blob/ee60ff6bef9fab48583253cd23b6da326cdac203/src/connection.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L34) - [ ] Read `ConsensusStates`: duplicated 3...

In the file [src/channel.rs](https://github.com/octopus-network/substrate-ibc/blob/9a4c0c36eb407b7066429e0efd60813ff2789d36/src/channel.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L220), there are a few conversions from Vec to Vec, which look redundant. ```rust let mut data: &[u8] = &data; let data = Vec::::decode(&mut data).unwrap(); ``` But...

Something tedious in engineering may occur when converting data structure between protobuf and substrate’s SCALE. Here's an example, which converting ibc-rs' `ClientState` to substrate's `ClientState`. * Define substrate's `ClientState`: https://github.com/cdot-network/substrate-ibc/commit/aa0e1b60bd56408bba34e52e910a3730f0cdb330#diff-bf7b01306aff35bb8c429e9d0b60028c041e7e93ab3453a60ec009420eebd53cL1-L39...

`height.increment()` not needed for Beefy

3

Hello, When implementing Beefy protocol, based on Grandpa consensus, there are 3 kinds of verifications in a hierarchical structure. * The top tier verification is MMR root verification, by collecting...

Demo wallet cannot display balances of users in local Oasis node correctly

1

I am developing on my local environment based on the [bridge paratime](https://github.com/oasisprotocol/oasis-bridge), which is not deployed to the testnet yet. In the [demo wallet](https://412-433workspace.slack.com/files/U01GD3DMK6Z/F026BDWMW23/wallet.zip), adding a custom node of "http://localhost:42280"...

There is [a sample js code](https://github.com/oasisprotocol/oasis-sdk/blob/main/client-sdk/ts-web/ext-utils/sample-page/src/index.js), which demos how to use the js API to connect to the wallet. But the sample js code can only connect to the sample-ext...

`commitment_proof` for non-Cosmos chain

2

Hello, We are working on the Substrate chain support of [ibc-rs](https://github.com/octopus-network/ibc-rs/tree/feature/beefy), which utilizes https://github.com/confio/ics23/tree/master/rust. The `CommitmentProof` has 4 variants [Exist, Nonexist, Batch, Compressed](https://github.com/informalsystems/ibc-rs/blob/aed240774df62b19099f796f2dd8459dabd72c88/proto/src/prost/std/ics23.rs#L56), none of them matches the structure of...