John Rayes
John Rayes
I notice that this function assumes that returning false short circuits utilis.each, similar to dom.traverse. Only... it doesn't. Was that an oversight or was each()never intended to short circuit?
Digging deeper to answer my own question, it seems that the code in question is a holdover from back when jQuery was used. I'll need to test it to see...
I'm converting this one to a draft for now until I can write up a bunch of unit tests for the possibility of compound tag matching.
Before i look into writing some tests for this, what are your thoughts @samclarke
I actually didn't think of that. I'm going to set this to target v4.0.0 because of the BC break. Might be silly since it is undocumented. And there may be...
Here's a build to test [sceditor.zip](https://github.com/samclarke/SCEditor/files/7309899/sceditor.zip)
@samclarke this is completely backwards compatible so could it go into v3.1.0? Was assigning it to v4.0.0 a mistake?
Did you try to push to your own fork? On Fri, Aug 13, 2021 at 1:20 AM Jamie T ***@***.***> wrote: > Hi @samclarke , I've create a fix but...
https://github.com/samclarke/SCEditor/pull/684
According to my understanding, v1 of SCE relied upon jQuery. Could we then also drop jQuery (seems to be used heavily in the tests)