SCEditor feat:Support excluded html tag attributes in bbcode formats with `false`

Mar 06 '21 07:03 live627

I notice that this function assumes that returning false short circuits utilis.each, similar to dom.traverse. Only... it doesn't. Was that an oversight or was each()never intended to short circuit?

Mar 06 '21 07:03 live627

Digging deeper to answer my own question, it seems that the code in question is a holdover from back when jQuery was used. I'll need to test it to see how it breaks things.

Mar 07 '21 03:03 live627

I'm converting this one to a draft for now until I can write up a bunch of unit tests for the possibility of compound tag matching.

Mar 08 '21 08:03 live627

Before i look into writing some tests for this, what are your thoughts @samclarke

Mar 20 '21 11:03 live627

Looks good, would be useful to have. It does look like it would change the behaviour of false in matching but as only null is documented that should be fine.

Mar 20 '21 23:03 samclarke

I actually didn't think of that. I'm going to set this to target v4.0.0 because of the BC break. Might be silly since it is undocumented. And there may be a chance that someone might be doing it that way.

Apr 14 '21 06:04 live627