LIU Yu
LIU Yu
Could be relevant: we encountered BlockingIOError when using ipython with uvloop. Also saw likewise report here https://github.com/ipython/ipython/issues/12563
Also note that, the initialization of custom CSR's may require access to the processor instance (i.e. to inspect a relevant feature / state of the processor). This is why there...
If an extension introduces custom CSR's to the processor, isn't it by definition modifying (extending) the processor's state? The bright side of `extension_t::reset()` is that its name explicitly suggests that...
> > > With your proposed solution, extensions developers would have to dig into spike's internal implementation (not just public interfaces) to find out that get_csrs() will get called during...
> It does seem like`extension_t::p` is unnecessary. The function signature for instructions already passes `processor_t*`. > > > Or, if we prefer explicitness to consistency, should we also refactor extension_t::reset()...
> It does seem like extension_t::p is unnecessary. The function signature for instructions already passes processor_t*. > > > Or, if we prefer explicitness to consistency, should we also refactor...
@arrv-sc thank you! The updated extension api looks good to me.