Liu Yiding
Liu Yiding
Hi, @clebergnu Thanks for your review and detailed explanatin. > Hi @liuyd96 , thanks for this contribution! > > Please take a look at the comments I made, and let's...
@clebergnu Gently ping ~
Hi, @clebergnu @Naresh-ibm Really appreciate your comments and detailed explanations. I benefited a lot from it. : ) I did a simple test to verify these changes i made. ```...
> LGTM @liuyd96 please take care of Travis failures. It's a timeout error of CI. ``` The job exceeded the maximum time limit for jobs, and has been terminated. ```
> @liuyd96 can you please rebase this request so we are good to go @PraveenPenguin Thanks for your info. I have rebased this request, please have a try. Thanks.
Hi, @Naresh-ibm @PraveenPenguin @clebergnu Thank you for your carefule review. I made some minor changes related to code formatting to pass the recently changed CI. :) Please review it. Thanks.
Close this PR since I have fulfilled it in avocado-vt.
> I don't know much about Java. I am using MacPorts and I've tried using the `openjdk16` package, the `openjdk16-zulu` package (which is the Azul version), and I've also installed...
Hi @refuseRed Please move your driver dir `deepsmart` from `SmartThingsEdgeDrivers/drivers` to `SmartThingsEdgeDrivers/` Just like `SmartThingsEdgeDrivers/drivers/Aqara`
Hi @refuseRed > Commits should be squashed down to a single commit prior to merging, as well as be rebased on top of the upstream branch 1. Add upstream repo...