Peter Lithammer

Results 66 comments of Peter Lithammer

GH-1678 is definitely an odd solution though (i.e. setting `/` as root). Most (all?) other language servers don't have this problem. Would it be better to look at improving the...

Is there a convenient way lookup that up besides manually searching through the Gemfile for something like `^\s*gem 'solargraph'`?

I suspect the confusion comes from the fact that the function is meant to take the path to a file, not a directory.

It seems like this is basically a duplicate of #7 (but less efficient).

Not sure why you're messing around with `go.mod` either?

Thanks for taking your time with this. I think I need to think about this for a bit, mainly because this was initially created to mimic Python's [`textwrap.dedent()`](https://docs.python.org/3.8/library/textwrap.html#textwrap.dedent) function. And...

Interesting, seems almost identical except that it trims whitespace from the beginning of the string. I will keep it open for while longer while I ponder things 🧐 I mean,...

It would be nice to see some benchmarks comparing them.

Thinking about this a bit more, I'm reluctant to replace the current implementation with something twice as slow with vague real-world advantages. I think a better approach would be to...

No particular reason. It seemed obvious at the time. It's a shame `string` doesn't implement `Stringer`, otherwise it would be an easy thing to change 🤷‍♂️ Now it would be...