Lisa Roach

Results 9 comments of Lisa Roach

I don't know why pyre is failing, I cannot get it to repro locally :( I did some digging to try to figure out what the plan was with the...

Created https://github.com/Instagram/LibCST/issues/475 for the LibCST bug

Thanks @jimmylai! No rush, I want to wait on this PR until after https://github.com/Instagram/LibCST/pull/476 is merged and released. I think it will clean up the code here nicely.

@zsol do you know when LibCST will be released again? I'd like to get this fix in :) Happy to help if I can!

There has been a new LibCST release so I am back looking at this. The bug in `TypeInferenceProviders` has been fixed but there is still a problem here: https://github.com/Instagram/LibCST/blob/e759ca8290585cf3badcd22ac5e1fdbc5e4f9e13/libcst/metadata/base_provider.py#L69 When...

> is this expecting to up-front merge all configs, and then apply the same merged configs to all paths being linted? No, that is not my intent. > presence of...

To get things moving here I'll work on implementing `allow_list_rules` and see if there are any objections on the PR

While waiting on review of #184, I'll put out my plan for what I think is the right design for inheritable configs (open to suggestions!). TL;DR on the post above,...