Eli

Results 430 comments of Eli

> Should be good to merge. _Originally posted by @lishaduck in https://github.com/jfmengels/node-elm-review/issues/201#issuecomment-2218011328_ CI seems to be flaking right now though.

> I don't know if we want a shrinkwrap though. Back in the days that was only recommended for applications. I haven't heard of that advice changing but I may...

> > > I don't know if we want a shrinkwrap though. Back in the days that was only recommended for applications. I haven't heard of that advice changing but...

Oh, just a small FYI: I've been focusing on some other OSS work recently, and I've just about finished it; however I've been working on my school Mac, but I'll...

> That is absolutely fine. Yeah, I just didn't want to seem like I was leaving a bunch of stuff unfinished, I'm just on a ~~brief~~ hiatus. >Thank you for...

> Note that when calling elm-format we do this: #49 > > So if this is wanted for the `elm` binary too, you could copy that. > > Just out...

> The thinking has been that if somebody installs elm-review globally, they’re gonna install elm globally too. Yeah. Again, I'd agree, but then someone's going to file an issue _someday_,...

> > but then someone's going to file an issue someday, so we might as well smoothen the path. > > It’s been years and nobody has asked for it....

> Does that mean that you run `./test/run.sh` directly instead of via `npm run test-run`? Sometimes. I mostly use turbo, but when I was writing #193, I did. Then I...

@jfmengels, I just figured out why we hit rate-limits so much: we run CI on push to any branch & on PRs, so it gets run twice.