Eli

Results 431 comments of Eli

> No, I don't think so. That plugin has an intentionally very opinionated set of rules for a specific use case. This rule is more of a general, lower-level building...

> I believe we've completed this in [#959](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/959) I believe that issue was for ranges, this is for the packages themselves (for example, the rule could be configured to ban...

Ok, so dug through the stacktraces and figured it out for the Vitest issue. `.storybook/vitest.setup.ts` calls `setProjectAnnotations` from `@storybook/sveltekit`, which sets `@storybook/svelte` as annotations, which also exports `.svelte` files, which...

Also, `isBrowser` is based on `window` instead of `document`, which means it's incorrect while running on Deno (and other modern runtimes). https://github.com/cloudinary/frontend-frameworks/blob/fbb7d159158090f639fea9eda981c962b9c985db/packages/html/src/utils/isBrowser.ts#L4-L6

And there's no `exports` field, so it can't get consumed as ESM and it doesn't use .mjs extension for ESM so it probably can't be imported even with an exports...

It's been a month! Would y'all be open to a PR(s) to clean up the repo? (Also, to double check, y'all don't have a CLA, do you?)

I will cite typescript-eslint/typescript-eslint#9311 as the reasoning against this sort of change. I'll need to think on this.

If anyone is looking for a working example of a migration, I've got this PR: lishaduck/legacy_checks#38.

> “melos bootstrap” command cannot be executed by you, right? (“melos bootstrap” command creates a ‘pubspec_overrides.yaml’ file for each module. Because of this, pub workspaces do not function properly) Right....

> Thanks @lishaduck but I used the 'melos bootstrap' command because it also generates *.iml files specific to modules in IntelliJ. Yeah, I use VS Code, which doesn't need them....