Liron Haim Lavy

Results 15 comments of Liron Haim Lavy

@antoninklopp Thanks for the CR, will fix the issues in the weekend, just wanted to say I forgot to add a comment about the source of the formula I used...

@danielcaldas @antoninklopp Thank you both for the quality code review.

> My biggest one is for custom node support. Should it be supported for now? Since it would be the user that should choose the symbol that is the closest...

@antoninklopp @danielcaldas This is no longer in a draft status for me.

@danielcaldas any idea why the node@10 test fails?

> > @danielcaldas any idea why the node@10 test fails? > > Hi @lironhl , > > I am not seeing any check failing. Which one are you referring to?...

@danielcaldas I'll find time to fix the PR in the following couple of days, let's hope for a merge in the span of the next two weeks!

> Hi @lironhl , > > Did you have any opportunity to fix the failing tests? > > I think that it would be really great if we could merge...

> I'll let @antoninklopp have a look at this one I think he's been involved in the PR discussions at a deeper level than me. @danielcaldas can you match @antoninklopp...

As written in the `Contributing` section of the `README.md`, you should run `npm run dev`, and be able to interact with the package in `http://localhost:3002/`.