Mat Lipe

Results 12 comments of Mat Lipe

I submitted pulls request to resolve this issue: 1. https://github.com/wp-cli/db-command/pull/231 2. https://github.com/wp-cli/wp-cli/pull/5689

I took another run at this and have so far been unable to recreate the issue. Every combination of fields, sorting, adding, sorting that I have tried has saved and...

I spent a couple more hours trying to recreate the issue to no avail. I have also been using this drag sorting on a couple projects without any reported issues....

@tw2113 Yes. Sorry about that :) I was testing against another branch and must have pushed. I have now cleaned up this feature branch.

> Fixed with #1142, so should be closed? #1142 Was just for single fields. This branch ads support for groups as well. @jtsternberg Not sure how I missed your comment...

Great find @daancjanssen ! Turns out there is one field in the entire plugin which requires special events to be trigger `wysiwyg`. I have added these events when sorting happens...

I submitted pull requests to resolve this issue: 1. https://github.com/wp-cli/db-command/pull/231 2. https://github.com/wp-cli/wp-cli/pull/5689

We've got discussions started in the pull requests working on a resolution. In the meantime you may use the Windows fork which has the pull requests pre-merged. https://github.com/lipemat/wp-cli-bundle/releases/tag/2.7.1-windows

That's kind of what I was thinking. Maybe add the `id` to the `$newRow` variable after a quick test for existence. If it is left out from a custom implementation...