lipchev

Results 124 comments of lipchev

This is almost done- still need to complete mapping in the JSON files, but as it stands I can only see one client call that is _breaking_ : `new UnitSystem(baseUnits).BaseUnits`...

@angularsen I've merged everything from upstream, removing the SupportsSIUnitSystem tests in favor of the auto-generated equivalents. There is one small thing that's been bugging me for a while- that is...

I don't know where to put this (maybe a discussion?) but [here](https://www.youtube.com/watch?v=bI-FS7aZJpY)'s a great explanation of the linear algebra behind the BaseUnits of different UnitSystems.

I have a few questions as to what the expectations are for the generic structs: 1. Suppose we get this to work on the structs - do we keep the...

> I don't think so? I can't think of any good reason why we should. float, double and decimal` might make sense. I knew I should have started with (9)...

Lol, I checked the Earth & Solar masses- turns out they are pretty big- ~6e24 & ~2e30 respectively- so I guess `decimal outOfRange = oneSolarMass.As(MassUnit.Kilograms)` is a dead end...It follows...

Maybe I misunderstand but you _can_ technically derive from the same name- as long as the namespace is different. However I think this is besides the point- as long as...

Yeah, I guess there is no way around it- other than going for some BigDecimal implementation (there were talks about Rationals before- so given the compiled lambdas flexibility - this...

I think we can include the GetHashCode and IComparable tests/fixes in #838 (even if we removed IEquatable).

As far as the UnitSystems - last I checked the implementation was ok for review. Or at least as a starting point (e.g. for v5). I didn't remove the BaseDimensions,...