Lionel Barrow comments

Repositories
Issues
Comments

Results 4 comments of


                                            Lionel Barrow

Update README to warn about keep-alive and graceful shutdown

Fixed in 3.0.0.

Update README to warn about keep-alive and graceful shutdown

I'll take another look, sorry for closing prematurely.

Update README to warn about keep-alive and graceful shutdown

Digging into this today. I see the problem -- if the shutdown command is received and then a request on a keepalive connection finishes, we close the connection correctly. But...

Serving + Closing in 2 separate routines is racy

This seems unlikely to cause real problems in production, but if it's causing the race detector to fire then 👍 .