Lionel Constantin

Results 10 comments of Lionel Constantin

> **License info**: > > 🔴 License found: `Creative Commons Attribution 4.0 International` (Not [OSI approved](https://opensource.org/licenses)) This is not correct. We have changed the licence to a BSD-3 licence for...

@kthyng Thanks for the feedback > * Can this be released to PyPI? Yes, I just setup the github action to release to pypi: https://pypi.org/project/emiproc/#description > > * Please reduce...

For reviewers I would suggest: - https://github.com/jcla490 - https://github.com/rwegener2 - https://github.com/dostuffthatmatters (in my non-conflicted extended network) - https://github.com/einaraz - https://github.com/varsha2509 - https://github.com/ibarraespinosa (same field, but in R and not python,...

> Great! I see it there. Please update your installation instructions too. Here it is: installation with pip: https://emiproc.readthedocs.io/en/master/installation.html

> An an example, line 27 has the reference in parentheses but it shouldn't be. > > As per the new comments, the paper length is now 1133. If you...

@kthyng What would be the next steps for the review ? Is it to contact reviewers ? https://github.com/openjournals/joss-reviews/issues/7337#issuecomment-2435229833

I have opened an issue for asking help. I will be away for one week (holidays) so I will continue working on this later on.

One point that i find wierd is that the validator seems to not like the Accession strings

@schymane Thanks for the answers, I managed to fix the format of our files. Before I add the whole library, is it possible to confirm/register our laboratory and the prefix...

> Hi Lionel, do you consider this contribution as complete? At the moment there are just two little issues left. One space too much and an empty table with peak...