Zhongpeng Lin

Results 100 comments of Zhongpeng Lin

I agree with https://github.com/jmhodges/bazel_gomock/pull/28#issuecomment-543095961, this PR is different from #28. This is more for convenience. If we know the full package path via `self_package`, the package name can be deduced...

@jmhodges Any more concerns on this PR?

The gomock rule can be feeded into a go_library rule like this: ```python gomock( name = "rosetta_mock", interfaces = ["Client"], library = ":go_default_library", package = "rosettamock", ) go_library( name =...

@jmhodges I updated the README. Can you take another look?

Can you make it support skipping multiple tests from different packages? Like: ``` go test -skip "pkg1.TestFoo|pkg2.TestBar" ./... ``` It would be useful to disable flaky tests in different packages...

Any plan to implement this? It seems not in Go 1.19 yet

I tried Python 3.6, 3.5 and 2.7 on Windows, but I can't reproduce the test failure. I will try running it on Linux. Also, from the Travis' log, I saw...

All tests passed now. Please take another look, @ankurankan

OK. Let me know when you are ready, so I can rebase

@Maria-MM If MemoryError occur for more than 15 nodes, how did you predict 300 nodes?